linux-kernel - Re: [patch 03/13] io-accounting: write accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <457FDDCE.7010303@FreeBSD.org>
Date:	Wed, 13 Dec 2006 03:02:38 -0800
From:	Suleiman Souhlal <ssouhlal@...eBSD.org>
To:	Suleiman Souhlal <ssouhlal@...eBSD.org>
CC:	Andrew Morton <akpm@...l.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org, balbir@...ibm.com, csturtiv@....com,
	daw@....com, guillaume.thouvenin@...l.net, jlan@....com,
	nagar@...son.ibm.com, tee@....com
Subject: Re: [patch 03/13] io-accounting: write accounting

Suleiman Souhlal wrote:
> Andrew Morton wrote:
> 
>> On Wed, 13 Dec 2006 00:45:50 -0800
>> Suleiman Souhlal <ssouhlal@...eBSD.org> wrote:
>>
>>
>>> akpm@...l.org wrote:
>>>
>>>> From: Andrew Morton <akpm@...l.org>
>>>>
>>>> Accounting writes is fairly simple: whenever a process flips a page 
>>>> from clean
>>>> to dirty, we accuse it of having caused a write to underlying 
>>>> storage of
>>>> PAGE_CACHE_SIZE bytes.
>>>
>>>
>>> On architectures where dirtying a page doesn't cause a page fault 
>>> (like i386), couldn't you end up billing the wrong process (in fact, 
>>> I think that even on other archituctures set_page_dirty() doesn't get 
>>> called immediately in the page fault handler)? 
>>
>>
>>
>> Yes, that would be a problem in 2.6.18 and earlier.
>>
>> In 2.6.19 and later, we do take a fault when transitioning a page from
>> pte-clean to pte-dirty.  That was done to get the dirty-page accounting
>> right - to avoid the 
>> all-of-memory-is-dirty-but-the-kernel-doesn't-know-it
>> problem.
> 
> 
> Ah yes indeed. I'm unable to keep up with all the new developments. :-(
> 
> However, if my understanding of this code is correct, it seems that the
> page fault is only done for shared writable VMAs, so you still can't
> rely on set_page_dirty() always being called by the process that
> dirtied the page in the first place.
> 
> Am I wrong?

Yes I am.
The only I/O non-shared VMAs might cause is from swapping, and I'm not
sure if the io accounting patches actually care about that.
My confusion came from the term "shared": A VMA is considered shared
whenever MAP_SHARED is specified, even if it only has only one single
"user".

-- Suleiman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/