lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 13 Dec 2006 14:05:59 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Andrew Morton <akpm@...l.org>, Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org
Subject: 2.6.19-mm1: gotemp: memset(..., 0) error

<--  snip  -->

...
NOT FOR MAINLINE!

This is for the driver tutorial I give.  It will not be included in the
mainline kernel tree ever.  Use the ldusb driver that is already there
instead for this device.

This is only a teaching tool.
...
+       pkt = kmalloc(sizeof(*pkt), GFP_ATOMIC);
+       if (!pkt)
+               return -ENOMEM;
+       memset(pkt, sizeof(*pkt), 0x00);
...

<--  snip  -->


Lesson 1:
Write an USB driver.

Lesson 2:
Correct the memset() argument order or use kzalloc().


cu
Adrian  ;-)

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ