linux-kernel - Re: Kevent POSIX timers support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061213132730.GA18244@2ka.mipt.ru>
Date:	Wed, 13 Dec 2006 16:27:31 +0300
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Tushar Adeshara <adesharatushar@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Kevent POSIX timers support.

Hello.

Please _NEVER_ drop Cc: list, since not everyone can be subscribed to
linux-kernel@, fortunately I'm not for example.

On Wed, Dec 13, 2006 at 06:51:47PM +0530, Tushar Adeshara (adesharatushar@...il.com) wrote:
> I think these four lines are not required. Irrespective of return
> value of kevent_user_add_ukevent(), we are going to release file, and
> return err.

> >+       if (err)
> >+               goto err_out_fput;
> >+
> >+       fput(file);
> >+
> >+       return 0;
> 
> 
> >+
> >+err_out_fput:
> >+       fput(file);
> >+err_out:
> >+       return err;
> >+}
> >+

I put them to always know where error path is and where it is not, so it
could be easier to put error statistic or debug.
It can be removed, but imho it reduces readability.

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/