linux-kernel - [PATCH] CONFIG_VM_EVENT_COUNTER comment decrustify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061213181956.6440.15235.sendpatchset@jackhammer.engr.sgi.com>
Date:	Wed, 13 Dec 2006 10:19:56 -0800
From:	Paul Jackson <pj@....com>
To:	Andrew Morton <akpm@...l.org>
Cc:	Paul Jackson <pj@....com>, linux-kernel@...r.kernel.org,
	Christoph Lameter <clameter@....com>
Subject: [PATCH] CONFIG_VM_EVENT_COUNTER comment decrustify

From: Paul Jackson <pj@....com>

The VM event counters, enabled by CONFIG_VM_EVENT_COUNTERS,
which provides VM event counters in /proc/vmstat, has become
more essential to non-EMBEDDED kernel configurations than they
were in the past.  Comments in the code and the Kconfig configuration
explanation were stale, downplaying their role excessively.

Refresh those comments to correctly reflect the current role of
VM event counters.

Signed-off-by: Paul Jackson <pj@....com>

---

Christoph and Andrew (I sure hope) understand what's the truth
here better than I.  I trust they won't hesitate to refine,
hack, mutilate, ignore or extend this patch, as appropriate.
						 - pj

 include/linux/vmstat.h |    5 +++--
 init/Kconfig           |    8 ++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

--- 2.6.19-mm1.orig/include/linux/vmstat.h	2006-12-12 04:12:59.850645800 -0800
+++ 2.6.19-mm1/include/linux/vmstat.h	2006-12-13 10:02:31.205199749 -0800
@@ -10,8 +10,9 @@
 /*
  * Light weight per cpu counter implementation.
  *
- * Counters should only be incremented and no critical kernel component
- * should rely on the counter values.
+ * Counters should only be incremented.  You need to set EMBEDDED
+ * to disable VM_EVENT_COUNTERS.  Things like procps (vmstat,
+ * top, etc) use /proc/vmstat and depend on these counters.
  *
  * Counters are handled completely inline. On many platforms the code
  * generated will simply be the increment of a global address.
--- 2.6.19-mm1.orig/init/Kconfig	2006-12-12 04:12:59.994647698 -0800
+++ 2.6.19-mm1/init/Kconfig	2006-12-13 10:12:17.424473564 -0800
@@ -483,10 +483,10 @@ config VM_EVENT_COUNTERS
 	default y
 	bool "Enable VM event counters for /proc/vmstat" if EMBEDDED
 	help
-	  VM event counters are only needed to for event counts to be
-	  shown. They have no function for the kernel itself. This
-	  option allows the disabling of the VM event counters.
-	  /proc/vmstat will only show page counts.
+	  VM event counters are needed for event counts to be shown.
+	  This option allows the disabling of the VM event counters
+	  on EMBEDDED systems.  /proc/vmstat will only show page counts
+	  if VM event counters are disabled.
 
 endmenu		# General setup
 

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@....com> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/