linux-kernel - Re: [RFC] Patch: dynticks: idle load balancing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061213224317.GA2986@elte.hu>
Date:	Wed, 13 Dec 2006 23:43:17 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Siddha, Suresh B" <suresh.b.siddha@...el.com>
Cc:	nickpiggin@...oo.com.au, vatsa@...ibm.com, clameter@....com,
	tglx@...utronix.de, arjan@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] Patch: dynticks: idle load balancing


* Siddha, Suresh B <suresh.b.siddha@...el.com> wrote:

> Appended patch attempts to fix the process idle load balancing in the 
> presence of dynticks. cpus for which ticks are stopped will sleep till 
> the next event wakes it up. Potentially these sleeps can be for large 
> durations and during which today, there is no idle load balancing 
> being done. There was some discussion happened(last year) on this 
> topic on lkml, where two main approaches were gettting debated. One is 
> to back off the idle load balancing for bigger intervals and the 
> second is a watchdog mechanism where the busy cpu will trigger the 
> load balance on an idle cpu.  Both of these mechanisms have its 
> drawbacks.

nice work! I have added your patch to -rt. Btw., it needs the patch 
below to work on 64-bit.

	Ingo

Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c
+++ linux/kernel/sched.c
@@ -1170,7 +1170,7 @@ static void resched_task(struct task_str
 static void resched_cpu(int cpu)
 {
 	struct rq *rq = cpu_rq(cpu);
-	unsigned int flags;
+	unsigned long flags;
 
 	spin_lock_irqsave(&rq->lock, flags);
 	resched_task(cpu_curr(cpu));
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/