linux-kernel - Re: [patch] net, 8139too.c: fix netpoll deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061213011231.GA6361@elte.hu>
Date:	Wed, 13 Dec 2006 02:12:31 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Jeff Garzik <jeff@...zik.org>, Linus Torvalds <torvalds@...l.org>,
	Andrew Morton <akpm@...l.org>,
	"David S. Miller" <davem@...emloft.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] net, 8139too.c: fix netpoll deadlock


* Francois Romieu <romieu@...zoreil.com> wrote:

> > (I'll queue it, if Linus doesn't pick it up; please CC me in the 
> > future)
> 
> I have lived with the "NAPI ->poll() handler runs in BH irq enabled 
> context" rule for years. Is it definitely false/dead ?
> 
> If so at least 8139cp needs the same fix.

hm, this isnt really about NAPI polling, but about the 
netconsole/netpoll/netdump poll_controller() handler.

with netconsole, printk can be called from IRQ context (and is 
frequently from IRQ context during bootup or module initialization), so 
a BH rule isnt enough for them.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/