linux-kernel - Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061212234145.557cb035@localhost.localdomain>
Date:	Tue, 12 Dec 2006 23:41:45 +0000
From:	Alan <alan@...rguk.ukuu.org.uk>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	akpm@...l.org, bzolnier@...il.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

> + * We work around this by initiating dummy, zero-length DMA transfer on
> + * a DMA timeout expiration. I found no better way to do this with the current

Novel workaround and probably better than resetting the chip as the
winbong does.

> +static int tc86c001_busproc(ide_drive_t *drive, int state)
> +{

Waste of space having a busproc routine. The maintainer removed all the
usable hotplug support from old IDE so this might as well be dropped.

> @@ -1407,6 +1407,24 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260a, quirk_intel_pcie_pm);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260b, quirk_intel_pcie_pm);
>  
> +/*
> + * Toshiba TC86C001 IDE controller reports the standard 8-byte BAR0 size
> + * but PIO transfer won't work if BAR0 falls at the odd 8 bytes.
> + * Re-allocate the region if needed.
> + */

NAK. I think this fixup should be testing if the device port 0 is in
native mode before doing the fixup. In comaptibility mode bar 0 is
ignored and the correct compatibility values set up in the resource tree
by the PCI layer as of 2.6.18-mm-mumble. They are also of course on a xx0
boundary.

"Close but no cookie": please fix the PCI quirk to match the current -mm
behaviour with the ATA resource tree. Otherwise - nice driver.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/