linux-kernel - Re: [GIT PATCH] more Driver core patches for 2.6.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0612141224190.6223@yvahk01.tjqt.qr>
Date:	Thu, 14 Dec 2006 12:26:12 +0100 (MET)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Linus Torvalds <torvalds@...l.org>
cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Greg KH <gregkh@...e.de>, Andrew Morton <akpm@...l.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH] more Driver core patches for 2.6.19


>  irqreturn_t uio_handler(...) {
>      disable interrupts for this dev;
>      set a flag that notifies userspace the next best time;
>      seomstruct->flag |= IRQ_ARRIVED;
>      return IRQ_HANDLED;
>  }

Rather than IRQ_HANDLED, it should have been: remove this irq handler 
from the irq handlers for irq number N, so that it does not get called 
again until userspace has acked it.

See, maybe I don't have enough clue yet to exactly figure out why you 
say it does not work. However, this is how simple people see it 8)


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/