linux-kernel - Re: 2.6.19-mm1: gotemp: memset(..., 0) error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061214235059.GA11375@kroah.com>
Date:	Thu, 14 Dec 2006 15:50:59 -0800
From:	Greg KH <greg@...ah.com>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: 2.6.19-mm1: gotemp: memset(..., 0) error

On Wed, Dec 13, 2006 at 02:05:59PM +0100, Adrian Bunk wrote:
> <--  snip  -->
> 
> ...
> NOT FOR MAINLINE!
> 
> This is for the driver tutorial I give.  It will not be included in the
> mainline kernel tree ever.  Use the ldusb driver that is already there
> instead for this device.
> 
> This is only a teaching tool.
> ...
> +       pkt = kmalloc(sizeof(*pkt), GFP_ATOMIC);
> +       if (!pkt)
> +               return -ENOMEM;
> +       memset(pkt, sizeof(*pkt), 0x00);
> ...
> 
> <--  snip  -->
> 
> 
> Lesson 1:
> Write an USB driver.
> 
> Lesson 2:
> Correct the memset() argument order or use kzalloc().

Heh, thanks, I've now fixed that up in my tree.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/