linux-kernel - Re: [PATCH/RFC] CodingStyle updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061214162605.b4b6f9f8.randy.dunlap@oracle.com>
Date:	Thu, 14 Dec 2006 16:26:05 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, akpm <akpm@...l.org>,
	jesper.juhl@...il.com
Subject: Re: [PATCH/RFC] CodingStyle updates

On Thu, 14 Dec 2006 19:07:27 -0500 (EST) Robert P. J. Day wrote:

> On Thu, 14 Dec 2006, Randy Dunlap wrote:
> 
> > David Weinehall wrote:
> > > On Thu, Dec 07, 2006 at 12:48:38AM -0800, Randy Dunlap wrote:
> > >
> > > [snip]
> > >
> > > > +but no space after unary operators:
> > > > +		sizeof  ++  --  &  *  +  -  ~  !  defined
> > >
> > > Uhm, that doesn't compute...  If you don't put a space after sizeof,
> > > the program won't compile.
> > >
> > > int c;
> > > printf("%d", sizeofc);
> >
> > Uh, we prefer not to see "sizeof c".  IOW, we prefer to have the
> > parentheses use all the time.  Maybe I need to say that better?
> 
> here's a *really* rough first pass, i'm sure the end result would need
> some hand tweaking:

You can certainly send such (generated) patches to Andrew or other
subsystem maintainers if you'd like, but I'm more interested in
not adding more crud to the tree in the future.

IOW, sure, we prefer sizeof(foo) to sizeof foo, but the latter isn't
killing us.  If someone is there making other changes, it would be
OK to change that also.

Compare:  http://lkml.org/lkml/2006/12/7/191

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/