linux-kernel - Re: [PATCH/v2] CodingStyle updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061215142206.GC2053@elf.ucw.cz>
Date:	Fri, 15 Dec 2006 15:22:06 +0100
From:	Pavel Machek <pavel@....cz>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	lkml <linux-kernel@...r.kernel.org>, jesper.juhl@...il.com,
	akpm <akpm@...l.org>
Subject: Re: [PATCH/v2] CodingStyle updates

Hi!

> Pavel Machek wrote:
> >> From: Randy Dunlap <randy.dunlap@...cle.com>
> >> +Use one space around (on each side of) most binary and ternary operators,
> >> +such as any of these:
> >> +	=  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=  ?  :
> > 
> > Actually, this should not be hard rule. We want to allow
> > 
> > 	j = 3*i + l<<2;
> 
> Which would be very misleading. This expression evaluates to
> 
> 	j = (((3 * i) + l) << 2);
> 
> Binary + precedes <<.

Aha, okay. So this one should be written as

	j = 3*i+l << 2;

(Well, parenthesses should really be used. Anyway, sometimes grouping
around operator is useful, even if I made mistake demonstrating that.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/