linux-kernel - Re: [PATCH 0/3] ensure unique i_ino in filesystems without permanent inode numbers (introduction)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4582B8AF.9060707@redhat.com>
Date:	Fri, 15 Dec 2006 10:01:03 -0500
From:	Jeff Layton <jlayton@...hat.com>
To:	Jörn Engel <joern@...ybastard.org>
CC:	akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH 0/3] ensure unique i_ino in filesystems without permanent
 inode numbers (introduction)

Jörn Engel wrote:
 > On Fri, 15 December 2006 08:05:24 -0500, Jeff Layton wrote:
 >> Jeff Layton wrote:
 >>> Apologies for the long email, but I couldn't come up with a way to explain
 >>> this in fewer words. Many filesystems that are part of the linux kernel
 >>> have problems with how they have assign out i_ino values:
 >>>
 >> If there are no further comments/suggestions on this patchset, I'd like to
 >> ask Andrew to add it to -mm soon and target getting it rolled into 2.6.21.
 >
 > I'm still unsure whether idr has a sufficient advantage over simply
 > hashing the inodes.  Hch has suggested that keeping the hashtable
 > smaller is good for performance.  But idr adds new complexity, which
 > should be avoided on its own right.  So is the performance benefit big
 > enough to add more complexity?  Is it even measurable?
 >
 > Jörn
 >


A very good question. Certainly, just hashing them would be a heck of a
lot simpler. That was my first inclination when I looked at this, but as
you said, HCH NAK'ed that idea stating that it would bloat out the
hashtable. I tend to think that it's probably not that significant, but
that might very much depend on workload.

I'm OK with either approach, though I'd like to have some sort of buyin
from Christoph on hashing the inodes before I start working on patches to
do that.

Christoph, care to comment?

-- Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/