linux-kernel - Re: [PATCH/v2] CodingStyle updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061215090037.05c021af.randy.dunlap@oracle.com>
Date:	Fri, 15 Dec 2006 09:00:37 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Scott Preece <sepreece@...il.com>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/v2] CodingStyle updates

On Fri, 15 Dec 2006 16:07:17 +0100 Pavel Machek wrote:

> On Fri 2006-12-15 08:52:22, Scott Preece wrote:
> > On 12/15/06, Pavel Machek <pavel@....cz> wrote:
> > >Hi!
> > >
> > >> Pavel Machek wrote:
> > >> >> From: Randy Dunlap <randy.dunlap@...cle.com>
> > >> >> +Use one space around (on each side of) most binary and ternary 
> > >operators,
> > >> >> +such as any of these:
> > >> >> +  =  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=  ?  :
> > >> >
> > >> > Actually, this should not be hard rule. We want to allow
> > >> >
> > >> >     j = 3*i + l<<2;
> > >>
> > >> Which would be very misleading. This expression evaluates to
> > >>
> > >>       j = (((3 * i) + l) << 2);
> > >>
> > >> Binary + precedes <<.
> > >
> > >Aha, okay. So this one should be written as
> > >
> > >        j = 3*i+l << 2;
> > >
> > >(Well, parenthesses should really be used. Anyway, sometimes grouping
> > >around operator is useful, even if I made mistake demonstrating that.
> > ---
> > 
> > I think the mistake illuminates why parentheses should be the rule. If
> > you're thinking about using spacing to convey grouping, use
> > parentheses instead...
> 
> Not in simple cases.
> 
> 	3*i + 2*j should be writen like that. Not like
> 	(3 * i) + (2 * j)

I would just write it as:
	3 * i + 2 * j

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/