linux-kernel - Re: [PATCH 2/4] Add MMC Password Protection (lock/unlock) support V8: mmc_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Dec 2006 18:24:29 +0100
From:	Pierre Ossman <drzeus-list@...eus.cx>
To:	Anderson Briglia <anderson.briglia@...t.org.br>
CC:	ext Frank Seidel <frank@...nalert.de>,
	Russell King <rmk+lkml@....linux.org.uk>,
	"Lizardo Anderson (EXT-INdT/Manaus)" <anderson.lizardo@...t.org.br>,
	linux-kernel@...r.kernel.org,
	"Aguiar Carlos (EXT-INdT/Manaus)" <carlos.aguiar@...t.org.br>,
	Tony Lindgren <tony@...mide.com>,
	ext David Brownell <david-b@...bell.net>
Subject: Re: [PATCH 2/4] Add MMC Password Protection (lock/unlock) support
 V8: mmc_key_retention.diff

Anderson Briglia wrote:
> The code was based on code presents at security/keys/user_defined.c. This is the reason of why the MMC PWD code was
> implemented using this returns types and others implementations.
> That file (user_defined.c) implements generic functions to handle keys inside the kernel, using the Kernel Key Retention
> Service. Maybe you can take a look there, :).
> That zap variable was used to expand the key payload when a new password exceeded a previous configured size. But the
> Kernel Key Retention Service has changed and that zap variable is not used on key_instantiate function implemented at
> user_defined.c, anymore. I'll update the MMC PWD code.
>
>   

Patches look ok, and I'll commit them once you send me this last fix.

> Yes. I believe sizeof is a compiler operation and it does not access the data pointed by that pointer, it access just
> the type of the pointer.
>
>   

Yes, sizeof() is compile time and completely safe in this regard.

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/