lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Dec 2006 10:20:39 -0800 From: Chris Wright <chrisw@...s-sol.org> To: linux-kernel@...r.kernel.org, stable@...nel.org Cc: akpm@...l.org, "Theodore Ts'o" <tytso@....edu>, Zwane Mwaikambo <zwane@....linux.org.uk>, Justin Forbes <jmforbes@...uxtx.org>, torvalds@...l.org, Chris Wedgwood <reviews@...cw.f00f.org>, Randy Dunlap <rdunlap@...otime.net>, Michael Krufky <mkrufky@...uxtv.org>, Dave Jones <davej@...hat.com>, Chuck Wolber <chuckw@...ntumlinux.com>, alan@...rguk.ukuu.org.uk, Arjan van de Ven <arjan@...ux.intel.com>, Andi Kleen <ak@...e.de> Subject: [patch 25/24] x86-64: Mark rdtsc as sync only for netburst, not for core2 2.6.18-stable review patch. If anyone has any objections, please let us know. ------------------ From: Arjan van de Ven <arjan@...ux.intel.com> On the Core2 cpus, the rdtsc instruction is not serializing (as defined in the architecture reference since rdtsc exists) and due to the deep speculation of these cores, it's possible that you can observe time go backwards between cores due to this speculation. Since the kernel already deals with this with the SYNC_RDTSC flag, the solution is simple, only assume that the instruction is serializing on family 15... The price one pays for this is a slightly slower gettimeofday (by a dozen or two cycles), but that increase is quite small to pay for a really-going-forward tsc counter. Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com> Signed-off-by: Andi Kleen <ak@...e.de> [chrisw: backported to 2.6.18] Signed-off-by: Chris Wright <chrisw@...s-sol.org> --- Commit: f3d73707a1e84f0687a05144b70b660441e999c7 Author: Arjan van de Ven <arjan@...ux.intel.com> Date: Thu Dec 7 02:14:12 2006 +0100 arch/x86_64/kernel/setup.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- linux-2.6.18.5.orig/arch/x86_64/kernel/setup.c +++ linux-2.6.18.5/arch/x86_64/kernel/setup.c @@ -1010,7 +1010,10 @@ static void __cpuinit init_intel(struct if ((c->x86 == 0xf && c->x86_model >= 0x03) || (c->x86 == 0x6 && c->x86_model >= 0x0e)) set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); - set_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability); + if (c->x86 == 15) + set_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability); + else + clear_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability); c->x86_max_cores = intel_num_cpu_cores(c); srat_detect_node(); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists