linux-kernel - Re: [PATCH] fsstack: Remove inode copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061215195341.GA31868@filer.fsl.cs.sunysb.edu>
Date:	Fri, 15 Dec 2006 14:53:41 -0500
From:	Josef Sipek <jsipek@....cs.sunysb.edu>
To:	Michael Halcrow <mhalcrow@...ibm.com>
Cc:	Andrew Morton <akpm@...l.org>, LKML <linux-kernel@...r.kernel.org>,
	"TREVOR S. HIGHLAND" <tshighla@...ibm.com>
Subject: Re: [PATCH] fsstack: Remove inode copy

On Fri, Dec 15, 2006 at 10:24:28AM -0600, Michael Halcrow wrote:
> The addition of copy_inode_size breaks eCryptfs, since eCryptfs needs
> to interpolate the file sizes (eCryptfs has extra space in the lower
> file for the header). The setting of the upper inode size occurs
> elsewhere in eCryptfs, and the new copy_attr_all now undoes what
> eCryptfs was doing right beforehand.
...
> I think the simplest solution, from eCryptfs' perspective, is to just
> remove the inode size copy. Jeff, please let me know if this approach
> will work for you, or let me know if you have another idea.
 
That's alright. fsstack is supposed to be as generic as possible. I think
that removing the inode size copy make it more generic.
 
> Remove inode size copy in general fsstack attr copy code. Stacked
> filesystems may need to interpolate the inode size, since the file
> size in the lower file may be different than the file size in the
> stacked layer.
> 
> Signed-off-by: Michael Halcrow <mhalcrow@...ibm.com>
Acked-by: Josef "Jeff" Sipek <jsipek@...sunysb.edu>

Josef "Jeff" Sipek.

-- 
Don't drink and derive. Alcohol and algebra don't mix.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/