linux-kernel - Re: sysfs file creation result nightmare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1166213773.31351.96.camel@localhost.localdomain>
Date:	Sat, 16 Dec 2006 07:16:13 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Andrew Morton <akpm@...l.org>,
	Olivier Galibert <galibert@...ox.com>,
	Paul Mackerras <paulus@...ba.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: sysfs file creation result nightmare

> Beware that sysfs_remove_bin_file() will complain loudly if you later
> attempt to delete that file that was never created.

That's another problem... what is a driver that creates 15 files
supposed to do ? Have 15 booleans to remember which files where
successfully created and then test all of them on cleanup ? That sounds
like even more bloat to me...

What about making sysfs_remove_bin_file() not complain ? It's common
practice to have disposal things not complain ... like kfree(NULL), or
the changes done recently so that misc_deregister() can be called even
if misc_register() failed etc...

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/