linux-kernel - Re: [S390] Fix reboot hang on LPARs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061215211558.GA8101@osiris.ibm.com>
Date:	Fri, 15 Dec 2006 22:15:58 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, holzheu@...ibm.com
Subject: Re: [S390] Fix reboot hang on LPARs

> +static int pgm_check_occured;
> +
> +static void cio_reset_pgm_check_handler(void)
> +{
> +	pgm_check_occured = 1;
> +}
> +
> +static int stsch_reset(struct subchannel_id schid, volatile struct schib *addr)
> +{
> +	int rc;
> +
> +	pgm_check_occured = 0;
> +	s390_reset_pgm_handler = cio_reset_pgm_check_handler;
> +	rc = stsch(schid, addr);
> +	s390_reset_pgm_handler = NULL;
> +	if (pgm_check_occured)
> +		return -EIO;
> +	else
> +		return rc;
> +}

This is broken. pgm_check_occured must be volatile, otherwise the -EIO path
in stsch_reset might get optimized away.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/