linux-kernel - Re: [patch 2/4] permission mapping for sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb97335b0612141721g2e983574k4ea698caa316de6d@mail.gmail.com>
Date:	Thu, 14 Dec 2006 17:21:25 -0800
From:	"Zack Weinberg" <zackw@...ix.com>
To:	"Randy Dunlap" <randy.dunlap@...cle.com>
Cc:	"Stephen Smalley" <sds@...ho.nsa.gov>, jmorris@...ei.org,
	"Chris Wright" <chrisw@...s-sol.org>, linux-kernel@...r.kernel.org
Subject: Re: [patch 2/4] permission mapping for sys_syslog operations

On 12/14/06, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> > +#define security_syslog_or_fail(type) do {           \
> > +             int error = security_syslog(type);      \
> > +             if (error)                              \
> > +                     return error;                   \
> > +     } while (0)
> > +
>
> From Documentation/CodingStyle:
>
> Things to avoid when using macros:
>
> 1) macros that affect control flow: ...

It says "avoid", not "never use".  If you can think of another way to
code this function that won't completely obscure the actual operations
with the security checks, I will be happy to change it.

zw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/