linux-kernel - Re: [PATCH] support HDIO_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45841FFD.8030907@garzik.org>
Date:	Sat, 16 Dec 2006 11:34:05 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	andersen@...epoet.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] support HDIO_GET_IDENTITY in libata

Erik Andersen wrote:
> On Thu Dec 14, 2006 at 03:31:30PM -0500, Jeff Garzik wrote:
>> Erik Andersen wrote:
>>> +			if (!atapi_enabled && dev->class == ATA_DEV_ATAPI) {
>> This seems like an impossible condition?
> 
> Hmm, suppose so.  Do you think that simply doing:
> 	if (dev->class == ATA_DEV_ATAPI) {
> here would be sufficient?

Yep.  There is also a selection of helpers in include/linux/libata.h 
starting with ata_class_enabled() that might be useful.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/