lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 16 Dec 2006 14:56:50 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Andrew Morton <akpm@...l.org>,
	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	linux-kernel@...r.kernel.org, B.Zolnierkiewicz@...a.pw.edu.pl,
	linux-ide@...r.kernel.org
Subject: [-mm patch] drivers/ide/pci/tc86c001.c: make a function static

On Thu, Dec 14, 2006 at 10:59:13PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-mm1:
>...
> +toshiba-tc86c001-ide-driver-take-2.patch
>...
>  Misc.
>...

This patch makes the needlessly global init_hwif_tc86c001() static.

Signed-off-by: Adrian Bunk <bunk@...sta.de>

---

BTW:
I'm not sure whether it'd be a good idea to include such a driver for 
the legacy IDE subsystem without a libata based driver for the same 
hardware.

--- linux-2.6.20-rc1-mm1/drivers/ide/pci/tc86c001.c.old	2006-12-15 21:58:44.000000000 +0100
+++ linux-2.6.20-rc1-mm1/drivers/ide/pci/tc86c001.c	2006-12-15 21:58:54.000000000 +0100
@@ -204,7 +204,7 @@
 	return 0;
 }
 
-void __devinit init_hwif_tc86c001(ide_hwif_t *hwif)
+static void __devinit init_hwif_tc86c001(ide_hwif_t *hwif)
 {
 	unsigned long sc_base	= pci_resource_start(hwif->pci_dev, 5);
 	u16 scr1		= hwif->INW(sc_base + 0x00);;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ