lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Dec 2006 20:16:12 +0100 From: Jean Delvare <khali@...ux-fr.org> To: Ralf Baechle <ralf@...ux-mips.org> Cc: Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org, lm-sensors@...sensors.org Subject: Re: [lm-sensors] [PATCH] Make lm70_remove a __devexit function Hi Ralf, On Sun, 10 Dec 2006 19:21:51 +0000, Ralf Baechle wrote: > Saves a few bytes on the module. > > Signed-off-by: Ralf Baechle <ralf@...ux-mips.org> > > diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c > index 6ba8473..7eaae38 100644 > --- a/drivers/hwmon/lm70.c > +++ b/drivers/hwmon/lm70.c > @@ -126,7 +126,7 @@ out_dev_reg_failed: > return status; > } > > -static int __exit lm70_remove(struct spi_device *spi) > +static int __devexit lm70_remove(struct spi_device *spi) > { > struct lm70 *p_lm70 = dev_get_drvdata(&spi->dev); > You're not actually saving memory with this change, as __devexit is resolved to either __exit (i.e. nothing changes) or nothing (i.e. the code is now always compiled in.) This is a bugfix though as currently the code may be striped away while the driver still holds a pointer to it. Good catch, applied (with a different header comment), thanks. -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists