linux-kernel - Re: [PATCH] fallout from atomic_long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0612171005440.3479@woody.osdl.org>
Date:	Sun, 17 Dec 2006 10:08:49 -0800 (PST)
From:	Linus Torvalds <torvalds@...l.org>
To:	Evgeniy Polyakov <johnpol@....mipt.ru>
cc:	Al Viro <viro@....linux.org.uk>,
	David Howells <dhowells@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fallout from atomic_long_t patch

On Sun, 17 Dec 2006, Evgeniy Polyakov wrote:
> 
> Delayed work was used to play with different timeouts and thus allow to
> smooth performance peaks, but then I dropped that idea, so timeout is always
> zero.

Ok, thanks for the explanation.

> I posted similar patch today to netdev@, which directly used
> work_pending instead of delayed_work_pending(), but if you will figure
> this out itself, I'm ok with proposed patch.

If I'm going to get the proper patch from the proper network trees, I'll 
just drop my patch. Whether you replace "delayed_work" with "work_struct" 
or not is not something I really care about - if you think you may want to 
play with the timeout idea in the future, please feel free to continue 
using delayed_work.

But if you do use delayed work, please use the "delayed_work_pending(&x)" 
function, rather than doing "work_pending(&x->work)" and knowing about the 
internals of how the delayed-work structure looks.

So with that out of the way, I'll just expect that I'll get whatever you 
decide on through Davem's git tree, once his drunken holiday revelry is 
over ;)

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/