linux-kernel - Re: kobject.h with HOTPLUG=n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061218195115.GA11312@kroah.com>
Date:	Mon, 18 Dec 2006 11:51:15 -0800
From:	Greg KH <greg@...ah.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>, kay.sievers@...y.org
Subject: Re: kobject.h with HOTPLUG=n

On Mon, Dec 18, 2006 at 09:49:24AM -0800, Randy Dunlap wrote:
> In 2.6.20-rc1-mm1, with HOTPLUG=n, 2 linux/kobject.h inline functions
> need to return <int>.  Currently this causes 962 warnings like this:
> 
> include/linux/kobject.h: In function 'kobject_uevent':
> include/linux/kobject.h:277: warning: no return statement in function 
> returning non-void
> include/linux/kobject.h: In function 'kobject_uevent_env':
> include/linux/kobject.h:281: warning: no return statement in function 
> returning non-void
> 
> Should these functions return 0 or some error code?
> 
> static inline int kobject_uevent(struct kobject *kobj, enum kobject_action 
> action) { }
> static inline int kobject_uevent_env(struct kobject *kobj,
> 				      enum kobject_action action,
> 				      char *envp[])
> { }

They should just return 0.  Care to make up a quick patch to fix this?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/