[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0612181652140.8141@localhost.localdomain>
Date: Mon, 18 Dec 2006 16:54:53 -0500 (EST)
From: "Robert P. J. Day" <rpjday@...dspring.com>
To: Erik Mouw <erik@...ddisk-recovery.com>
cc: Linux kernel mailing list <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] Add a new section to CodingStyle, promoting
include/linux/kernel.h.
On Mon, 18 Dec 2006, Erik Mouw wrote:
> On Mon, Dec 18, 2006 at 12:43:35PM -0500, Robert P. J. Day wrote:
> > Add a new section to the CodingStyle file, encouraging people not to
> > re-invent available kernel macros such as ARRAY_SIZE(),
> > FIELD_SIZEOF(), min() and max(), among others.
>
> Good stuff. Could you also mention the printk() KERN_ALERT etc.
> levels? I've seen quite some people using "<1>" on the kernelnewbies
> list.
they may be using it on that list, but there's very little of that in
the kernel source itself. this is the only example i found:
$ grep -r '<[0-7]>' * | grep printk
arch/ppc/syslib/m8260_pci_erratum9.c: printk("<4>Using IDMA%d for MPC8260 device erratum PCI 9 workaround\n",
maybe i'll submit a patch to clean that one up.
rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists