linux-kernel - [PATCH] tlclk: delete unnecessary sysfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20061219085712.GM4049@APFDCB5C>
Date:	Tue, 19 Dec 2006 17:57:12 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Sebastien Bouchard <sebastien.bouchard@...kontron.com>,
	Mark Gross <mark.gross@...el.com>
Subject: [PATCH] tlclk: delete unnecessary sysfs_remove_group

It is unnecessary and invalid to call sysfs_remove_group()
after sysfs_create_group() failure.

Cc: Sebastien Bouchard <sebastien.bouchard@...kontron.com>
Cc: Mark Gross <mark.gross@...el.com>
Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>

---
 drivers/char/tlclk.c |    2 --
 1 file changed, 2 deletions(-)

Index: 2.6-mm/drivers/char/tlclk.c
===================================================================
--- 2.6-mm.orig/drivers/char/tlclk.c
+++ 2.6-mm/drivers/char/tlclk.c
@@ -807,8 +807,6 @@ static int __init tlclk_init(void)
 			&tlclk_attribute_group);
 	if (ret) {
 		printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n");
-		sysfs_remove_group(&tlclk_device->dev.kobj,
-			&tlclk_attribute_group);
 		goto out5;
 	}
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/