| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20061219000234.GA5330@localdomain> Date: Tue, 19 Dec 2006 02:02:34 +0200 From: Dan Aloni <da-x@...atomic.org> To: Linux Kernel List <linux-kernel@...r.kernel.org> Cc: linux-scsi@...r.kernel.org, Mike Christie <michaelc@...wisc.edu> Subject: [PATCH] scsi_execute_async() should add to the tail of the queue Hello, scsi_execute_async() has replaced scsi_do_req() a few versions ago, but it also incurred a change of behavior. I noticed that over-queuing a SCSI device using that function causes I/Os to be starved from low-level queuing for no justified reason. I think it makes much more sense to perserve the original behaviour of scsi_do_req() and add the request to the tail of the queue. Signed-off-by: Dan Aloni <da-x@...atomic.org> diff -p -urN a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c --- a/drivers/scsi/scsi_lib.c 2006-12-19 01:48:50.000000000 +0200 +++ b/drivers/scsi/scsi_lib.c 2006-12-19 01:49:35.000000000 +0200 @@ -421,7 +421,7 @@ int scsi_execute_async(struct scsi_devic sioc->data = privdata; sioc->done = done; - blk_execute_rq_nowait(req->q, NULL, req, 1, scsi_end_async); + blk_execute_rq_nowait(req->q, NULL, req, 0, scsi_end_async); return 0; free_req: -- Dan Aloni XIV, http://www.xivstorage.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists