linux-kernel - Re: [PATCH] Add support for Korenix 16C950-based PCI cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Dec 2006 16:33:10 +0300
From:	Andrey Panin <pazke@...pac.ru>
To:	Linux Kernel List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>,
	Linus Torvalds <torvalds@...l.org>
Subject: Re: [PATCH] Add support for Korenix 16C950-based PCI cards

On 347, 12 13, 2006 at 02:45:46PM +0000, Russell King wrote:
> Linus, Andrew,
> 
> This patch adds initial support to 8250-pci for the Korenix Jetcard PCI
> serial cards.  The JC12xx cards are standard RS232-based serial cards
> utilising the Oxford 16C950 device.
> 
> The JC14xx are RS422/RS485-based cards, but in order for these to be
> supported natively, we will need additional tweaks to the 8250 layers
> so we can specify some values for the 950's registers.  Hence, these
> two entries are commented out.

IIRC 16c950 just need two bits in ACR set properly. Will attached patch 
do the trick ?

> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> 
>  drivers/serial/8250_pci.c |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c
> index 4d0ff8f..89c3f2c 100644
> --- a/drivers/serial/8250_pci.c
> +++ b/drivers/serial/8250_pci.c
> @@ -2239,6 +2239,30 @@ static struct pci_device_id serial_pci_t
>  		pbn_b0_bt_1_460800 },
>  
>  	/*
> +	 * Korenix Jetcard F0/F1 cards (JC1204, JC1208, JC1404, JC1408).
> +	 * Cards are identified by their subsystem vendor IDs, which
> +	 * (in hex) match the model number.
> +	 *
> +	 * Note that JC140x are RS422/485 cards which require ox950
> +	 * ACR = 0x10, and as such are not currently fully supported.
> +	 */
> +	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
> +		0x1204, 0x0004, 0, 0,
> +		pbn_b0_4_921600 },
> +	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
> +		0x1208, 0x0004, 0, 0,
> +		pbn_b0_4_921600 },
> +/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
> +		0x1402, 0x0002, 0, 0,
> +		pbn_b0_2_921600 }, */
> +/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
> +		0x1404, 0x0004, 0, 0,
> +		pbn_b0_4_921600 }, */
> +	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1,
> +		0x1208, 0x0004, 0, 0,
> +		pbn_b0_4_921600 },
> +
> +	/*
>  	 * Dell Remote Access Card 4 - Tim_T_Murphy@...l.com
>  	 */
>  	{	PCI_VENDOR_ID_DELL, PCI_DEVICE_ID_DELL_RAC4,

-- 
Andrey Panin		| Linux and UNIX system administrator
pazke@...pac.ru		| PGP key: wwwkeys.pgp.net

View attachment "patch-ACR" of type "text/plain" (1351 bytes)