linux-kernel - Re: [PATCH 4/10] cxgb3 - HW access routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Dec 2006 15:00:24 -0800
From:	Divy Le Ray <divy@...lsio.com>
To:	Arjan van de Ven <arjan@...radead.org>
CC:	jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, swise@...ngridcomputing.com
Subject: Re: [PATCH 4/10] cxgb3 - HW access routines - part 2

Arjan van de Ven wrote:
>> +void t3_port_intr_disable(struct adapter *adapter, int idx)
>> +{
>> +	struct cphy *phy = &adap2pinfo(adapter, idx)->phy;
>> +
>> +	t3_write_reg(adapter, XGM_REG(A_XGM_INT_ENABLE, idx), 0);
>> +	phy->ops->intr_disable(phy);
>>     
>
> you seem to be missing a pci posting flush here....
>   
Thanks for catching this. Will fix.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/