lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Dec 2006 19:29:13 -0800 From: David Brownell <david-b@...bell.net> To: Andrew Morton <akpm@...l.org> Cc: Matthew Garrett <mjg59@...f.ucam.org>, Arjan van de Ven <arjan@...radead.org>, linux-kernel@...r.kernel.org, gregkh@...e.de Subject: Re: Changes to sysfs PM layer break userspace On Tuesday 19 December 2006 6:15 pm, Andrew Morton wrote: > On Tue, 19 Dec 2006 13:34:49 -0800 > David Brownell <david-b@...bell.net> wrote: > > > Documentation/feature-removal-schedule.txt has warned about this since > > August > > Nobody reads that. > > Please, wherever possible, put a nice printk("this is going away") in the code > when planning these things. Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net> Index: g26/drivers/base/power/sysfs.c =================================================================== --- g26.orig/drivers/base/power/sysfs.c 2006-09-27 16:19:00.000000000 -0700 +++ g26/drivers/base/power/sysfs.c 2006-12-19 19:27:25.000000000 -0800 @@ -42,9 +42,17 @@ static ssize_t state_show(struct device static ssize_t state_store(struct device * dev, struct device_attribute *attr, const char * buf, size_t n) { + static int warned; pm_message_t state; int error = -EINVAL; + if (!warned) { + printk(KERN_WARNING + "*** WARNING *** sysfs devices/.../power/state files " + "are only for testing, and will be removed\n"); + warned = error; + } + /* disallow incomplete suspend sequences */ if (dev->bus && (dev->bus->suspend_late || dev->bus->resume_early)) return error; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists