[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200612192015.14587.david-b@pacbell.net>
Date: Tue, 19 Dec 2006 20:15:14 -0800
From: David Brownell <david-b@...bell.net>
To: Matthew Garrett <mjg59@...f.ucam.org>
Cc: linux-kernel@...r.kernel.org, gregkh@...e.de
Subject: Re: Changes to PM layer break userspace
On Tuesday 19 December 2006 7:43 pm, Matthew Garrett wrote:
> > Do you have an alternate solution?
>
> How about something like this? Entirely untested, but I think it shows
> the basic idea.
Other than indentation/whitespace bugs, it seems to encapsulate the
layering violation needed to get those deprecated files working again
for PCI (and platform_bus). I'd rename the new bus method though;
maybe "pm_has_noirq_stage()" or somesuch. Your name is so generic that
it'd be a surprise if the answer were ever "no"!
You should also list this new call in the feature-removal.txt entry for
stuff that gets removed with /sys/devices/.../power/state files, since
it's another mechanism that only exists to prop up that broken API,
and should vanish at the same time that API does.
- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists