linux-kernel - Re: [patch 2.6.20-rc1 3/6] AT91 GPIO wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200612202245.21524.david-b@pacbell.net>
Date:	Wed, 20 Dec 2006 22:45:20 -0800
From:	David Brownell <david-b@...bell.net>
To:	Andrew Morton <akpm@...l.org>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Victor <andrew@...people.com>,
	Bill Gatliff <bgat@...lgatliff.com>,
	Haavard Skinnemoen <hskinnemoen@...el.com>, jamey.hicks@...com,
	Kevin Hilman <khilman@...sta.com>,
	Nicolas Pitre <nico@....org>,
	Russell King <rmk@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>,
	pHilipp Zabel <philipp.zabel@...il.com>
Subject: Re: [patch 2.6.20-rc1 3/6] AT91 GPIO wrappers

On Wednesday 20 December 2006 10:10 pm, Andrew Morton wrote:
> On Wed, 20 Dec 2006 13:11:19 -0800
> David Brownell <david-b@...bell.net> wrote:
> 
> > +static inline int gpio_get_value(unsigned gpio)
> > +	{ return at91_get_gpio_value(gpio); }
> > +
> > +static inline void gpio_set_value(unsigned gpio, int value)
> > +	{ (void) at91_set_gpio_value(gpio, value); }
> 
> whaa?  Where'd we pull that coding style from?

School of concision.  Notice also the clever ";) at the end of each line.


> Please,

I see you fixed this in what you merged to MM; thanks.

- Dave


> static inline int gpio_get_value(unsigned gpio)
> {
> 	return at91_get_gpio_value(gpio);
> }
> 
> static inline void gpio_set_value(unsigned gpio, int value)
> {
> 	at91_set_gpio_value(gpio, value);
> }
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/