[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061219162608.6085d8aa@freekitty>
Date: Tue, 19 Dec 2006 16:26:08 -0800
From: Stephen Hemminger <shemminger@...l.org>
To: Francois Romieu <romieu@...zoreil.com>
Cc: Arjan van de Ven <arjan@...radead.org>,
Matthew Garrett <mjg59@...f.ucam.org>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Network drivers that don't suspend on interface down
On Thu, 21 Dec 2006 01:11:12 +0100
Francois Romieu <romieu@...zoreil.com> wrote:
> Stephen Hemminger <shemminger@...l.org> :
> [...]
> > IMHO:
> > When device is down, it should:
> > a) use as few resources as possible:
> > - not grab memory for buffers
> > - not assign IRQ unless it could get one
> > - turn off all power consumption possible
> > b) allow setting parameters like speed/duplex/autonegotiation,
> > ring buffers, ... with ethtool, and remember the state
> > c) not accept data coming in, and drop packets queued
>
> <nit>
> Imho speed/duplex/autoneg is not the business of the device: they belong
> to the phy and it's up to it to decide if its state allows to set the
> requested parameters or not.
> </nit>
>
We need to allow ethtool setting to be done before device has been brought
up and started autonegotiation. The current MII library doesn't really support
it.
--
Stephen Hemminger <shemminger@...l.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists