linux-kernel - Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Dec 2006 08:08:14 -0700
From:	"Gordon Farquharson" <gordonfarquharson@...il.com>
To:	"Linus Torvalds" <torvalds@...l.org>
Cc:	"Andrew Morton" <akpm@...l.org>,
	"Martin Michlmayr" <tbm@...ius.com>,
	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>,
	"Hugh Dickins" <hugh@...itas.com>,
	"Nick Piggin" <nickpiggin@...oo.com.au>,
	"Arjan van de Ven" <arjan@...radead.org>,
	"Andrei Popa" <andrei.popa@...eo.ro>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Florian Weimer" <fw@...eb.enyo.de>,
	"Marc Haber" <mh+linux-kernel@...schlus.de>,
	"Martin Schwidefsky" <schwidefsky@...ibm.com>,
	"Heiko Carstens" <heiko.carstens@...ibm.com>,
	"Arnd Bergmann" <arnd.bergmann@...ibm.com>
Subject: Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

On 12/21/06, Linus Torvalds <torvalds@...l.org> wrote:

> Andrew located at least one bug: we run cancel_dirty_page() too late in
> "truncate_complete_page()", which means that do_invalidatepage() ends up
> not clearing the page cache.
>
> His patch is appended.

Thanks. I'll try this out later today.

> But it sounds like I probably misunderstood something, because I thought
> that Martin had acknowledged that this patch actually worked for him.
> Which sounded very similar to your setup (he has a 32M ARM box too, no?)

Yup, we have the same machines (Linksys NSLU2) and are running the
same test case (installing Debian). However, I'm not sure what kernel
version he had used for his latest test. I presumed 2.6.20-git,
whereas I had used 2.6.19.

> Maybe it's mount option issue? I've got data=ordered on my machine, are
> you perhaps runnign with something else?

We are also using ordered.

/dev/scsi/host0/bus0/target0/lun0/part1 /target ext3 rw,data=ordered 0 0

Gordon

-- 
Gordon Farquharson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/