| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Dec 2006 22:30:34 +0100 From: Jean Delvare <khali@...ux-fr.org> To: Thomas Meyer <thomas@...3r.de>, Linus Torvalds <torvalds@...l.org>, Steve French <sfrench@...ba.org> Cc: linux-kernel@...r.kernel.org Subject: Re: WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined! On Fri, 22 Dec 2006 15:28:45 +0100, Thomas Meyer wrote: > Again current git head: > > I guess this should be fixed by someone! > > WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined! > make[1]: *** [__modpost] Fehler 1 > make: *** [modules] Fehler 2 This is caused by this commit: http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fba2591bf4e418b6c3f9f8794c9dd8fe40ae7bd9 >From the log message: "Some filesystems need to be fixed up for this: CIFS, FUSE, JFS, ReiserFS, XFS all use the old confusing functions, and will be fixed separately in subsequent commits (with some of them just removing the offending logic, and others using clear_page_dirty_for_io())." The approach seems quite broken to me, the users should have been fixed _before_ removing the function, so as to avoid compilation failures. These are a pain for testers, and break git bisect too. Grmbl. Now that it's done... Steve, can you please take a look and provide a patch so that cifs builds again? Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists