linux-kernel - Re: [powerpc] Fix bogus BUG_ON() in in hugetlb_get_unmapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E5477CAE-3FE8-4441-9225-570DD0679765@kernel.crashing.org>
Date:	Fri, 22 Dec 2006 01:31:26 +0100
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	David Gibson <david@...son.dropbear.id.au>
Cc:	Andrew Morton <akpm@...l.org>, Paul Mackerras <paulus@...ba.org>,
	libhugetlbfs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	William Lee Irwin <wli@...omorphy.com>,
	linuxppc-dev@...abs.org
Subject: Re: [powerpc] Fix bogus BUG_ON() in in hugetlb_get_unmapped_area()

> +	if (len > TASK_SIZE)
> +		return -ENOMEM;

Shouldn't that be addr+len instead?  The check looks incomplete
otherwise.  And you meant ">=" I guess?

> -		/* Paranoia, caller should have dealt with this */
> -		BUG_ON((addr + len) > 0x100000000UL);
> -

Any real reason to remove the paranoia check?  If it's trivially
always satisfied, the compiler will get rid of it for you :-)

Cheers,


Segher

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/