| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 23 Dec 2006 11:40:37 +0000 From: Russell King <rmk+lkml@....linux.org.uk> To: Arnaud Patard <apatard@...driva.com> Cc: David Brownell <david-b@...bell.net>, Linux Kernel list <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>, Andrew Victor <andrew@...people.com>, Bill Gatliff <bgat@...lgatliff.com>, Haavard Skinnemoen <hskinnemoen@...el.com>, jamey.hicks@...com, Kevin Hilman <khilman@...sta.com>, Nicolas Pitre <nico@....org>, Tony Lindgren <tony@...mide.com>, pHilipp Zabel <philipp.zabel@...il.com>, Ben Dooks <ben-linux@...ff.org> Subject: Re: [patch 2.6.20-rc1 6/6] S3C2410 GPIO wrappers On Thu, Dec 21, 2006 at 11:33:11AM +0100, Arnaud Patard wrote: > > +#include <asm/arch/irqs.h> > > imho, this is not needed. The user who will use irq will add it in his > code anyway. > > > +#include <asm/arch/hardware.h> This is a pet peave. _NO_ drivers should include either of these two headers directly. Use asm/irq.h and asm/hardware.h instead. Audit your code to ensure that you're including the right headers please. I can see that I've got to do another sweep of the entire kernel code to fix all these again. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists