linux-kernel - Re: [patch] suspend: fix suspend on single-CPU systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061223232915.GA2763@atrey.karlin.mff.cuni.cz>
Date:	Sun, 24 Dec 2006 00:29:15 +0100
From:	Pavel Machek <pavel@....cz>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...l.org>, linux-kernel@...r.kernel.org,
	Siddha@...e.hu, Suresh B <suresh.b.siddha@...el.com>,
	Clark Williams <williams@...hat.com>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [patch] suspend: fix suspend on single-CPU systems

> Subject: [patch] suspend: fix suspend on single-CPU systems
> From: Ingo Molnar <mingo@...e.hu>
> 
> Clark Williams reported that suspend doesnt work on his laptop on 
> 2.6.20-rc1-rt kernels. The bug was introduced by the following cleanup 
> commit:
> 
>  commit 112cecb2cc0e7341db92281ba04b26c41bb8146d
>  Author: Siddha, Suresh B <suresh.b.siddha@...el.com>
>  Date:   Wed Dec 6 20:34:31 2006 -0800
> 
>     [PATCH] suspend: don't change cpus_allowed for task initiating the suspend
> 
> because with this change 'error' is not initialized to 0 anymore, if 
> there are no other online CPUs. (i.e. if the system is single-CPU).
> 
> the fix is the initialize it to 0. The really weird thing is that my 
> version of gcc does not warn about this non-initialized variable 
> situation ...
> 
> (also fix the kernel printk in the error branch, it was missing a
>  newline)
> 
> Reported-by: Clark Williams <williams@...hat.com>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Looks okay to me.

-- 
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/