linux-kernel - Re: [patch] net/xfrm: fix crash in ipsec audit logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1167158252.3746.4.camel@localhost>
Date:	Tue, 26 Dec 2006 13:37:32 -0500
From:	jamal <hadi@...erus.ca>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	Linus Torvalds <torvalds@...l.org>, dwmw2@...radead.org,
	Joy Latten <latten@...tin.ibm.com>
Subject: Re: [patch] net/xfrm: fix crash in ipsec audit logging

On Tue, 2006-26-12 at 18:56 +0100, Ingo Molnar wrote:


> +	xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
> +		       AUDIT_MAC_IPSEC_DELSPD, delete, xp, NULL);
> +
>  	if (!delete) {
>  		struct sk_buff *resp_skb;


You could move the call into the else from above if (!delete) maybe?
Otherwise you have to add back the "if (delete)" check since that
function could be used to either retrieve (which is not subject to an
audit) or delete an xp.

cheers,
jamal
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/