linux-kernel - Re: [PATCH] Remove logically superfluous comparisons from Kconfig files.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200612271303.kBRD3tSJ007866@laptop13.inf.utfsm.cl>
Date:	Wed, 27 Dec 2006 10:03:55 -0300
From:	"Horst H. von Brand" <vonbrand@....utfsm.cl>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Remove logically superfluous comparisons from Kconfig files. 

Robert P. J. Day <rpjday@...dspring.com> wrote:
>   Remove Kconfig comparisons of the form FUBAR || FUBAR=n, since they
> appear to be superfluous.
> 
> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> 
> ---
> 
>   based on what i read in kconfig-language.txt, it would *appear* that
> those comparisons are redundant, but i'm willing to be convinced
> otherwise.  (unless the developer specifically wanted the case of
> "!=m", which i'm fairly sure is not the same thing, yes?)

Would be clearer written that way if so.

>  drivers/char/drm/Kconfig   |    2 +-
>  fs/dlm/Kconfig             |    1 -
>  net/ipv4/netfilter/Kconfig |    1 -
>  net/sctp/Kconfig           |    1 -
>  4 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/char/drm/Kconfig b/drivers/char/drm/Kconfig
> index ef833a1..d681e68 100644
> --- a/drivers/char/drm/Kconfig
> +++ b/drivers/char/drm/Kconfig
> @@ -6,7 +6,7 @@
>  #
>  config DRM
>  	tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
> -	depends on (AGP || AGP=n) && PCI
> +	depends on && PCI
                   ^^ ???

>  	help
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/