linux-kernel - Re: [patch] block: remove BKL dependency from drivers/block/loop.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Dec 2006 16:47:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	linux-kernel@...r.kernel.org
Cc:	Andrew Morton <akpm@...l.org>, Jens Axboe <axboe@...e.de>
Subject: Re: [patch] block: remove BKL dependency from drivers/block/loop.c


* Ingo Molnar <mingo@...e.hu> wrote:

> Subject: [patch] block: remove BKL dependency from drivers/block/loop.c
> From: Ingo Molnar <mingo@...e.hu>
> 
> the block loopback device is protected by lo->lo_ctl_mutex and it does 
> not need to hold the BKL anywhere. Convert its ioctl to unlocked_ioctl 
> and remove the BKL acquire/release from its compat_ioctl.

hm, i must have messed up this bit:

> +static long lo_ioctl(struct file * file, unsigned int cmd, unsigned long arg)
>  {
> +	struct inode *inode = file->f_path.dentry->d_inode;
>  	struct loop_device *lo = inode->i_bdev->bd_disk->private_data;

because it now crashes there ... so forget this patch for now.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/