linux-kernel - Re: [FSAIO][PATCH 7/8] Filesystem AIO read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061228085623.b6c74840.randy.dunlap@oracle.com>
Date:	Thu, 28 Dec 2006 08:56:23 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Suparna Bhattacharya <suparna@...ibm.com>, linux-aio@...ck.org,
	akpm@...l.org, drepper@...hat.com, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, jakub@...hat.com, mingo@...e.hu
Subject: Re: [FSAIO][PATCH 7/8] Filesystem AIO read

On Thu, 28 Dec 2006 17:22:07 +0100 (MET) Jan Engelhardt wrote:

> 
> On Dec 28 2006 11:57, Christoph Hellwig wrote:
> >
> >> +
> >> +		if ((error = __lock_page(page, current->io_wait))) {
> >> +			goto readpage_error;
> >> +		}
> >
> >This should  be
> >
> >		error = __lock_page(page, current->io_wait);
> >		if (error)
> >			goto readpage_error;
> 
> That's effectively the same. Essentially a style thing, and I see if((err =
> xyz)) not being uncommon in the kernel tree.

The combined if/assignment has been known to contain coding errors
that are legal C, just not what was intended.

Since the latter replacement shouldn't cause any code efficiency
problems and it's more readable, it's becoming preferred.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/