linux-kernel - Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061228205055.GA2311@elf.ucw.cz>
Date:	Thu, 28 Dec 2006 21:50:55 +0100
From:	Pavel Machek <pavel@....cz>
To:	David Brownell <david-b@...bell.net>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>,
	Andrew Victor <andrew@...people.com>,
	Bill Gatliff <bgat@...lgatliff.com>,
	Haavard Skinnemoen <hskinnemoen@...el.com>, jamey.hicks@...com,
	Kevin Hilman <khilman@...sta.com>,
	Nicolas Pitre <nico@....org>,
	Russell King <rmk@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>,
	pHilipp Zabel <philipp.zabel@...il.com>
Subject: Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

Hi!

> > > From: Philipp Zabel <philipp.zabel@...il.com>
> > 
> > Missing s-o-b?
> 
> Yes, still ...
> 
> > > +static inline int gpio_direction_input(unsigned gpio)
> > > +{
> > > +	if (gpio > PXA_LAST_GPIO)
> > > +		return -EINVAL;
> > > +	pxa_gpio_mode(gpio | GPIO_IN);
> > > +}
> > 
> > Missing return 0?
> > 
> > > +static inline int gpio_direction_output(unsigned gpio)
> > > +{
> > > +	if (gpio > PXA_LAST_GPIO)
> > > +		return -EINVAL;
> > > +	pxa_gpio_mode(gpio | GPIO_OUT);
> > > +}
> > > +
> > 
> > And here?
> 
> You're looking at about the oldest version of that patch.
> Admittedly there were too many floating around...

I think I've looked at the newer ones, too, and this particular return
was _not_ fixed.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/