[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200612281410.31981.david-b@pacbell.net>
Date: Thu, 28 Dec 2006 14:10:31 -0800
From: David Brownell <david-b@...bell.net>
To: Arjan van de Ven <arjan@...radead.org>
Cc: Adam Belay <abelay@...ell.com>, ambx1@....rr.com,
Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [patch 2.6.12-rc2] PNP: export pnp_bus_type
On Thursday 28 December 2006 2:05 am, Arjan van de Ven wrote:
>
> > Hmm, then maybe it'd be worth updating that patch I just sent so that
> > the only change is to switch #includes for the extern decl ... i.e. to
> > "export" it only to other statically linked kernel code, rather than to
> > modules. I'll do that.
> >
> > My own question about that EXPORT_SYMBOL was whether it instead be
> > an EXPORT_SYMBOL_GPL, but if either one costs bytes ... I'm happy to
> > avoid that cost!
>
> no export if it's not *really* need is obviously superior to either of
> those so yes I like the patch you're talking about already without even
> having seen it ;)
The change is trivial ... in pnp/driver.c strike the EXPORT_SYMBOL.
So I won't bother posting it to this list; I hate wasting electrons.
I sent the updated patch to Andrew, but evidently just missed his
2.6.20-rc2-mm1 cutoff.
- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists