linux-kernel - Re: [PATCH] Use correct macros in raid code, not raw asm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0612281549080.4473@woody.osdl.org>
Date:	Thu, 28 Dec 2006 15:51:59 -0800 (PST)
From:	Linus Torvalds <torvalds@...l.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
cc:	Andi Kleen <ak@....de>, Andrew Morton <akpm@...l.org>,
	Ingo Molnar <mingo@...e.hu>, Neil Brown <neilb@...e.de>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	virtualization <virtualization@...ts.osdl.org>
Subject: Re: [PATCH] Use correct macros in raid code, not raw asm



On Fri, 29 Dec 2006, Rusty Russell wrote:
>
> This make sure it's paravirtualized correctly when CONFIG_PARAVIRT=y.

Why doesn't this code use "kernel_fpu_begin()" and "kernel_fpu_end()"?

The raid6 code is crap, and slower. It does "fsave/frstor" or movaps or 
other crud, and the thing is, it shouldn't. It should just do 
kernel_fpu_begin/end(), which does it all right, and avoids saving any 
state at all unless it's being used by the user RIGHT NOW.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/