linux-kernel - Re: [PATCH] Sanely size hash tables when using large base pages.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Dec 2006 09:29:34 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] Sanely size hash tables when using large base pages.

On Tue, Dec 26, 2006 at 03:42:57PM +0800, Fengguang Wu wrote:
> On Tue, Dec 26, 2006 at 03:16:52PM +0900, Paul Mundt wrote:
> >  	pidhash_shift = max(4, fls(megabytes * 4));
> >  	pidhash_shift = min(12, pidhash_shift);
> >  	pidhash_size = 1 << pidhash_shift;
> >  
> > +	size = pidhash_size * sizeof(struct hlist_head);
> > +	if (unlikely(size < PAGE_SIZE)) {
> > +		size = PAGE_SIZE;
> > +		pidhash_size = size / sizeof(struct hlist_head);
> > +		pidhash_shift = 0;
> 
> But pidhash_shift is not the order of page ;-)
> 
Ah, you're right. I'll drop the pidhash changes and resubmit. Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/