linux-kernel - Re: [patch] change WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061228091548.GA24765@elte.hu>
Date:	Thu, 28 Dec 2006 10:15:48 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Pavel Machek <pavel@....cz>
Cc:	Andrew Morton <akpm@...l.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Linus Torvalds <torvalds@...l.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] change WARN_ON back to "BUG: at ..."

* Pavel Machek <pavel@....cz> wrote:

> > But lots of people have now written downstream log-parsing tools 
> > which might break due to this change, so I'm inclined to go with 
> > Ingo's patch, and restore the old (il)logic.
> 
> People should not be parsing syslog. If they do, they deserve 
> occassional breakage.

so what other method do you propose to those who are working on 
increasing the reliability of the kernel by running automatic regression 
tests and boot allyesconfig kernels, to figure out whether out of the 
tons of kernel logs there was any problem? Right now "^BUG: " is a 
pretty universal filter, and i dont see a problem in preserving that.

(for lockdep there's a 'debug_locks' line in /proc/lockdep_stats that 
tells us whether any lock related assert was printed by the kernel, and 
my scripts monitor that. Along that line we could introduce a 
/proc/sys/kernel/bugs counter for tools to monitor. But even after that, 
you have to find the place in the syslog so having a text signature for 
kernel bugs is still a good idea.)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/