linux-kernel - Re: Want comments regarding patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0612301206090.26556@yvahk01.tjqt.qr>
Date:	Sat, 30 Dec 2006 12:07:43 +0100 (MET)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Bodo Eggert <7eggert@....de>
cc:	Daniel Marjamäki <daniel.marjamaki@...il.com>,
	Arjan van de Ven <arjan@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: Want comments regarding patch


On Dec 30 2006 01:00, Bodo Eggert wrote:
>Jan Engelhardt <jengelh@...ux01.gwdg.de> wrote:
>> On Dec 29 2006 07:57, Daniel Marjamäki wrote:
>
>>> It was my goal to improve the readability. I failed.
>>>
>>> I personally prefer to use standard functions instead of writing code.
>>> In my opinion using standard functions means less code that is easier to
>>> read.
>> 
>> Hm in that case, what about having something like
>> 
>> void *memset_int(void *a, int x, int n) {
>>     asm("mov %0, %%esi;
>>          mov %1, %%eax;
>>          mov %2, %%ecx;
>>          repz movsd;",
>>        a,x,n);
>> }
>
>This would copy the to-be-initialized buffer somewhere, if it compiles.

Yeah I don't do assembler soo often that I would know everything from heart.
All your comments are valid of course. I just wanted to point out the idea.
(However, if it's not repz, then it's repnz! :-)

	-`J'
--