linux-kernel - [PATCH -mm] fix for crash in adummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20061230154941.176582000@mvista.com>
Date:	Sat, 30 Dec 2006 07:49:41 -0800
From:	Daniel Walker <dwalker@...sta.com>
To:	akpm@...l.org
CC:	mingo@...e.hu
Subject: [PATCH -mm] fix for crash in adummy_init()

This was reported by Ingo Molnar here,

http://lkml.org/lkml/2006/12/18/119

The problem is that adummy_init() depends on atm_init() , but adummy_init() is
called first.

So I put atm_init() into subsys_initcall which seems appropriate, and it will
still get module_init() if it becomes a module.

Interesting to note that you could crash your system here if you just load the
modules in the wrong order.

Signed-Off-By: Daniel Walker <dwalker@...sta.com>

---
 net/atm/common.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.19/net/atm/common.c
===================================================================
--- linux-2.6.19.orig/net/atm/common.c
+++ linux-2.6.19/net/atm/common.c
@@ -816,7 +816,8 @@ static void __exit atm_exit(void)
 	proto_unregister(&vcc_proto);
 }
 
-module_init(atm_init);
+subsys_initcall(atm_init);
+
 module_exit(atm_exit);
 
 MODULE_LICENSE("GPL");
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/