linux-kernel - Re: [PATCH 1/1] Char: tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 31 Dec 2006 19:08:12 +0100
From:	Tilman Schmidt <tilman@...p.cc>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Hansjoerg Lipp <hjlipp@....de>
Subject: Re: [PATCH 1/1] Char: tty_wakeup cleanup

On Sat, 16 Dec 2006 23:17:00 +0100 (CET), Jiri Slaby wrote:
> tty_wakeup cleanup
> 
> - remove wake_up_interruptible(&tty->write_wait) surrounding
>   tty_wakup(tty);
> - substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty);
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>

Acked-by: Tilman Schmidt <tilman@...p.cc>

(for drivers/isdn/gigaset/interface.c)

> ---
> commit 2acac8f970a75a3dc8466781845ae5d14c3d8988
> tree 396cc84d4e198d2a65cd4aa9748aabeab5681ba5
> parent 8b380d8b1c3ff7d09d68d467d2f135774cab4086
> author Jiri Slaby <jirislaby@...il.com> Sat, 16 Dec 2006 22:22:57 +0059
> committer Jiri Slaby <jirislaby@...il.com> Sat, 16 Dec 2006 22:22:57 +0059
[...]
> diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
> index 458b646..f13de20 100644
> --- a/drivers/isdn/gigaset/interface.c
> +++ b/drivers/isdn/gigaset/interface.c
> @@ -599,19 +599,9 @@ out:
>  static void if_wake(unsigned long data)
>  {
>  	struct cardstate *cs = (struct cardstate *) data;
> -	struct tty_struct *tty;
> -
> -	tty = cs->tty;
> -	if (!tty)
> -		return;
> -
> -	if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
> -	    tty->ldisc.write_wakeup) {
> -		gig_dbg(DEBUG_IF, "write wakeup call");
> -		tty->ldisc.write_wakeup(tty);
> -	}
>  
> -	wake_up_interruptible(&tty->write_wait);
> +	if (cs->tty)
> +		tty_wakeup(cs->tty);
>  }
>  
>  /*** interface to common ***/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/